ci: only install binding dependencies when building binary #9429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #9429 will not alter performanceComparing 🎉 Hooray!
|
LingyuCoder
force-pushed
the
ci/improve-build-pnpm-install
branch
from
0b3b05a to
d6e665a
Compare
SyMind
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is no need to install the whole pnpm workspace dependencies when building binary
This pull request includes updates to the GitHub Actions workflows and custom actions to add more control over dependency installation and caching. The changes introduce a new input parameter to conditionally run the installation steps and update the workflows to use this new parameter.
Key changes:
Updates to
.github/actions/pnpm-cache/action.yml:run-installinput parameter to control whether the installation steps should be executed.run-installinput parameter. [1] [2] [3] [4]Updates to
.github/workflows/ci.yml:full-installinput parameter to several jobs to control whether the full installation should be performed. [1] [2] [3]pnpm-cacheaction with the newrun-installparameter.Updates to
.github/workflows/reusable-build.yml:full-installinput parameter to control the installation process.Pnpm Cachestep to use therun-installparameter.full-installis not set to true.Checklist